Parallelize CI lint jobs and switch to Debug variant by jkmassel · Pull Request #22637 · wordpress-mobile/WordPress-Android

jkmassel · 2026-02-27T19:05:09Z

Summary

Switch lint from Release to Debug variant (faster compilation, no R8)
Disable checkDependencies for app-level lint, avoiding redundant analysis of transitive dependencies
Move locale consistency checks into a separate parallel CI job
Split library lint (editor, image-editor) into separate parallel jobs
Regenerate lint baseline for Debug variant with MissingNullAnnotation checks excluded (Java-only, not relevant for Kotlin-first codebase – anything that has this warning is a prime candidate for replacement by Kotlin code)
Remove references to removed Vanilla build flavour and login module

CI timing comparison

Job	Trunk	PR	Change
Lint WordPress	4m 14s	4m 32s	+18s
Lint Jetpack	6m 10s	4m 29s	-1m 41s
Lint libs:editor	(inline)	3m 34s	(new parallel job)
Lint libs:image-editor	(inline)	3m 22s	(new parallel job)
Locale Consistency	(inline)	3m 1s	(new parallel job)
Developer wait time	6m 10s	4m 32s	-27%

Developer wait time is determined by the slowest job in the parallel group. The bottleneck shifts from Jetpack lint (6m 10s) to WordPress lint (4m 32s).

Trade-offs

checkDependencies false means lint won't detect issues in library module sources from app-level lint. Library modules are now linted in their own dedicated CI jobs instead.
Baseline was regenerated for the Debug variant. 357 entries from dependency analysis were removed (now covered by separate lib lint jobs). Net baseline size decreased from 731 to 390 non-MissingNullAnnotation issues.

Test plan

Lint WordPress job passes
Lint Jetpack job passes
Locale Consistency job passes
Lint libs:editor job passes
Lint libs:image-editor job passes
No new lint failures from variant/dependency changes
Timing validated across multiple CI runs

🤖 Generated with Claude Code

Move locale consistency checks into a separate parallel CI job and disable checkDependencies for app-level lint. This removes ~4-6 min of gem install + fastlane overhead from each lint job's critical path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The baseline was generated with checkDependencies=true, so switching it off causes 234 baseline entries to become "fixed" and surfaces new UnusedResources errors. Reverting until the baseline can be regenerated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Set checkDependencies=false for app-level lint to avoid scanning the entire dependency tree - Add add_ignore_attr to local library string configs so merged strings are not flagged as unused without dependency checking - Add separate CI lint jobs for editor, login, and image-editor libraries to maintain lint coverage Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

wpmobilebot · 2026-02-27T20:00:37Z

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Build Type	Debug
	Version	pr22637-b4661f6
	Build Number	`1488`
	Application ID	`com.jetpack.android.prealpha`
	Commit	`b4661f6`
	Installation URL	1vkn14rvcpq7o

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-02-27T20:01:36Z

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Build Type	Debug
	Version	pr22637-b4661f6
	Build Number	`1488`
	Application ID	`org.wordpress.android.prealpha`
	Commit	`b4661f6`
	Installation URL	4k418ovncuj18

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

The baseline was generated with checkDependencies=true, which meant dependency-sourced issues were included. With checkDependencies=false, the baseline needs to reflect app-module-only lint results. This also captures MissingNullAnnotation warnings that were always present but never baselined. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

With checkDependencies=false, lint can't see that certain resources defined in the app are used by editor/login library modules. Add targeted ignore rules in lint.xml for these specific resources instead of regenerating the entire baseline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Debug variants skip R8/ProGuard minification during compilation, which reduces lint wall time especially on cold caches. All app code is identical between debug and release — BuildConfig.DEBUG checks are runtime conditionals, not compile-time code removal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Resolve conflicts: - lint.sh: Keep VanillaDebug variants (PR intent: faster lint) - localization.rb: Keep add_ignore_attr (needed with checkDependencies disabled), drop removed Login Library module Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The login module was removed in PR #22564. Remove the now-invalid libs:login lint CI step and login-specific lint ignore rules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The Vanilla flavour no longer exists. Use lintWordpressDebug and lintJetpackDebug instead of the non-existent VanillaDebug variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Switching to Debug caused 357 baseline mismatches (the baseline was generated against Release). Regenerating the baseline would balloon it from 8k to 65k lines. Keep Release variant — the speedup from this PR comes from checkDependencies=false, parallel lib lints, and separating locale checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Lint Debug is faster than Release (no R8/minification). The blocker was 5,124 MissingNullAnnotation issues that only surface on Debug, ballooning the baseline from 8k to 65k lines. Ignoring these checks entirely (they were already partially suppressed for generated code) allows a clean switch to Debug with a net baseline reduction (8k -> 4k lines). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

dangermattic · 2026-04-01T22:44:28Z

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Test code accounts for ~20% of source files but generates ~64% of baseline issues (mostly DoNotMockDataClass). Skipping test source analysis should meaningfully reduce lint wall time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

This reverts commit d8f4072.

sonarqubecloud · 2026-04-01T23:51:55Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

This PR optimizes CI lint/validation throughput by switching app lint to Debug, disabling dependency checking for lint, and parallelizing previously-serial checks into separate Buildkite steps.

Changes:

Switch WordPress/Jetpack lint tasks to Debug variants and disable lint.checkDependencies.
Split locale consistency and selected library lint into separate parallel Buildkite jobs.
Update lint configuration/baseline behavior to match the new Debug + no-dependency-analysis setup.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`fastlane/lanes/localization.rb`	Adjusts library string merge settings to match the new lint/dependency behavior.
`config/lint/lint.xml`	Updates ignored lint issues and adds suppressions for resources now “invisible” with `checkDependencies=false`.
`build.gradle`	Disables lint dependency checking at the app level.
`.buildkite/pipeline.yml`	Adds parallel Locale Consistency + library lint steps alongside existing lint jobs.
`.buildkite/commands/lint.sh`	Switches app lint commands (and SARIF path) from Release to Debug variants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T08:41:03Z

.buildkite/pipeline.yml

+          if .buildkite/commands/should-skip-job.sh --job-type validation; then
+            exit 0
+          fi
+


The Locale Consistency step uses should-skip-job.sh --job-type validation, which (per should-skip-job.sh) will skip when changes are limited to fastlane/**, config/**, and **/strings.xml. Since this job’s purpose is to validate Fastlane locale lists vs Gradle resourceConfigurations, skipping on those files can let inconsistencies slip through. Consider using a job-type/skip rule that still runs when fastlane/lanes/localization.rb (and related locale config) changes, or adjust the skip logic for this step accordingly.

Suggested change

if .buildkite/commands/should-skip-job.sh --job-type validation; then

exit 0

fi

Copilot · 2026-04-02T08:41:03Z

.buildkite/pipeline.yml

+      - label: "🕵️ Lint libs:editor"
+        command: |
+          if .buildkite/commands/should-skip-job.sh --job-type lint; then
+            exit 0
+          fi
+
+          .buildkite/commands/restore-cache.sh
+          ./gradlew :libs:editor:lint
+        plugins: [$CI_TOOLKIT]


This job runs ./gradlew :libs:editor:lint. If the intent is to lint the Debug variant for speed (matching the app lint switch to Debug), consider invoking the variant-specific task (e.g., :libs:editor:lintDebug) to avoid running additional variants. Also consider adding artifact_paths for lint reports (like the app lint steps) so failures are debuggable from CI artifacts.

Copilot · 2026-04-02T08:41:03Z

.buildkite/pipeline.yml

+          ./gradlew :libs:image-editor:lint
+        plugins: [$CI_TOOLKIT]


Same as the editor lint step: ./gradlew :libs:image-editor:lint may run more than the Debug variant. If the goal is Debug-only lint for faster CI, prefer the variant-specific lint task (e.g., :libs:image-editor:lintDebug). Also add artifact_paths for lint reports so the job produces the same diagnostics as the app lint steps.

Suggested change

./gradlew :libs:image-editor:lint

plugins: [$CI_TOOLKIT]

./gradlew :libs:image-editor:lintDebug

plugins: [$CI_TOOLKIT]

artifact_paths:

- "**/build/reports/lint-results*.*"

Copilot · 2026-04-02T08:41:04Z

config/lint/lint.xml

+        <ignore path="**/res/color/aztec_format_button_selector_color.xml" />
+        <ignore path="**/res/color/primary_on_surface_disabled_selector.xml" />
+        <ignore path="**/res/values-night/colors_aztec.xml" />


The new UnusedResources ignores use very broad paths like **/res/color/..., which will suppress findings anywhere those filenames appear across the repo. To reduce the chance of hiding legitimate issues in other modules later, consider narrowing these ignores to the specific module path where these resources live (e.g., WordPress/src/main/res/...).

Suggested change

<ignore path="**/res/color/aztec_format_button_selector_color.xml" />

<ignore path="**/res/color/primary_on_surface_disabled_selector.xml" />

<ignore path="**/res/values-night/colors_aztec.xml" />

<ignore path="**/libs/editor/src/main/res/color/aztec_format_button_selector_color.xml" />

<ignore path="**/libs/editor/src/main/res/color/primary_on_surface_disabled_selector.xml" />

<ignore path="**/libs/editor/src/main/res/values-night/colors_aztec.xml" />

ParaskP7 · 2026-04-02T10:42:19Z

👋 @jkmassel and team, I went through the changes and below my suggestions: (love the extra Lint speed btw ❤️ )

Suggestion (💡): Consider using DOAndroid's approach to have Lint run on debug for PR builds, but on release for trunk builds. This way you wouldn't get blocked while releasing the apps on cases where Lint fails only for release builds. See DOAndroid's:
- pipeline.yml
- lint.sh

FYI: From the above, you'll also notice that the DOAndroid team gets notified on Slack when such a Lint related trunk failure occurs.

Suggestion (💡): Consider merging both the 🕵️ Lint libs:editor and 🕵️ Lint libs:image-editor into one job, and move that config within lint.sh itself. Then use it like wordpress and jetpack, command: .buildkite/commands/lint.sh library. The config can look something like:

if [ "$1" = "library" ]; then
  ./gradlew :libs:editor:lint :libs:image-editor:lint
  exit 0
fi

I am sure that doing the above wouldn't make this lint.sh library slower than any of the other lint.sh wordpress and lint.sh jetpack jobs, so you won't lose in speed, and actually save a Buildkite resource.

FYI: In addition, to fully replicate the previous checkDependencies true, I suggest adding all available Android libraries (modules) into that lint.sh library check, the rest of them are:

libs:analytics
libs:fluxc (?)
libs:mocks
libs:networking
libs:posttypes

if [ "$1" = "library" ]; then
  ./gradlew :libs:analytics:lint :libs:editor:lint :libs:fluxc:lint :libs:image-editor:lint :libs:mocks:lint :libs:networking:lint :libs:posttypes:lint :libs:image-editor:lint
  exit 0
fi

PS: Obviously, and as per Copilot's commends (here + here), use lintDebug instead of lint, or else lint"${BUILD_VARIANT^}", that is, if you also take the 1st suggestion above into consideration.

Let me know what you think! 💭

jkmassel and others added 3 commits February 27, 2026 12:04

jkmassel and others added 6 commits February 27, 2026 13:07

Trigger rebuild to measure debug lint with warm cache

51d4fad

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove login module references from CI and lint config

aac21e8

The login module was removed in PR #22564. Remove the now-invalid libs:login lint CI step and login-specific lint ignore rules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jkmassel marked this pull request as ready for review April 1, 2026 21:21

Fix lint tasks for removed Vanilla build flavour

35968ee

The Vanilla flavour no longer exists. Use lintWordpressDebug and lintJetpackDebug instead of the non-existent VanillaDebug variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jkmassel added this to the 26.8 milestone Apr 1, 2026

jkmassel self-assigned this Apr 1, 2026

jkmassel added Tooling Performance labels Apr 1, 2026

jkmassel and others added 2 commits April 1, 2026 15:55

jkmassel and others added 3 commits April 1, 2026 17:07

Trigger CI re-run for timing validation

2019f37

Disable lint on test sources for faster CI

d8f4072

Test code accounts for ~20% of source files but generates ~64% of baseline issues (mostly DoNotMockDataClass). Skipping test source analysis should meaningfully reduce lint wall time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Revert "Disable lint on test sources for faster CI"

b4661f6

This reverts commit d8f4072.

jkmassel changed the title ~~Speed up CI lint jobs~~ Parallelize CI lint jobs and switch to Debug variant Apr 1, 2026

jkmassel requested review from ParaskP7 and nbradbury April 1, 2026 23:51

jkmassel assigned adalpari Apr 1, 2026

ParaskP7 requested a review from Copilot April 2, 2026 08:32

Copilot started reviewing on behalf of ParaskP7 April 2, 2026 08:33 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parallelize CI lint jobs and switch to Debug variant#22637

Parallelize CI lint jobs and switch to Debug variant#22637
jkmassel wants to merge 15 commits intotrunkfrom
jkmassel/investigate-lint-speed

jkmassel commented Feb 27, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 27, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 27, 2026 •

edited

Loading

Uh oh!

dangermattic commented Apr 1, 2026

Uh oh!

sonarqubecloud bot commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

ParaskP7 commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	if .buildkite/commands/should-skip-job.sh --job-type validation; then
	exit 0
	fi

Conversation

jkmassel commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

CI timing comparison

Trade-offs

Test plan

Uh oh!

wpmobilebot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangermattic commented Apr 1, 2026

Uh oh!

sonarqubecloud bot commented Apr 1, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

ParaskP7 commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jkmassel commented Feb 27, 2026 •

edited

Loading

wpmobilebot commented Feb 27, 2026 •

edited

Loading

wpmobilebot commented Feb 27, 2026 •

edited

Loading